Delay loading securerandom until after bundler setup#372
Merged
Conversation
On ruby 3.x you can get an error like this if you run this without securerandom:0.4.1 (required by the lockfile) installed: > in `check_for_activated_spec!': You have already activated securerandom 0.3.1, but your Gemfile requires securerandom 0.4.1. Since securerandom is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports securerandom as a default gem. (Gem::LoadError)
tekknolagi
approved these changes
Aug 4, 2025
Contributor
tekknolagi
left a comment
tekknolagi
left a comment
There was a problem hiding this comment.
does the relative positioning of the env var section and the harness loader require matter?
Contributor
Author
|
No we just need any gems to be loaded after the use_gemfile call.
I didn't need to move the loader, I just did it because the env vars
weren't influencing that and it seemed more consistent to have it first.
|
k0kubun
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On ruby 3.x you can get an error like this if you run this without
securerandom:0.4.1 (required by the lockfile) installed: